Skip to content

feat(variables): add JSON external secret UI - #3093

Draft
TheoGrandin74 wants to merge 17 commits into
stagingfrom
feat/secret-manager-json-integration
Draft

feat(variables): add JSON external secret UI#3093
TheoGrandin74 wants to merge 17 commits into
stagingfrom
feat/secret-manager-json-integration

Conversation

@TheoGrandin74

@TheoGrandin74 TheoGrandin74 commented Oct 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Adds a JSON external-secret option to the variables page and service-creation flow. Users select a secret-manager source and reference, enter the JSON key to import, and choose its resulting environment-variable name.

Behavior

  • A shared Add secret dropdown offers variable, file, and JSON options in both flows.
  • JSON secrets require Key name and Secret name. Secret name follows Key name until manually edited, after which the fields remain independent. Editing an existing secret preserves its saved Secret name.
  • Rows display Secret name in the Name column, with the JSON icon and Key name underneath.
  • Search operates on reference-level fields, and each reference counts as one external secret.
  • Submission errors appear in the modal and allow retry.

API integration pending

JSON Add, Edit, and Delete currently operate on local drafts. Variables-page drafts reset on remount. Creation-flow drafts stay in form state but are not persisted during service creation. TODO comments identify the API integration points.

Before shipping, connect JSON persistence and service creation to the API, validate Secret name conflicts against existing variables and secrets with backend enforcement, and complete JSON analytics.

Validation

  • 32 focused tests passed across the external-secrets modal/table and service-creation variables suites, covering required fields, autofill, unlinking after override, editing, local CRUD, and failed-submit retry.
  • Console TypeScript, formatting, and whitespace checks passed.
  • Changed-file lint passed with one existing useless-fragment warning.
  • Full repository test coverage is not confirmed; the repository-wide run encountered timeouts.

@nx-cloud

nx-cloud Bot commented Oct 12, 2026 •
edited
Loading

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit ac57956

Command Status Duration Result
nx run console:build --parallel=3 --configurati... ✅ Succeeded 1m 16s View ↗
nx affected --target=test --parallel=3 --config... ✅ Succeeded 3m 47s View ↗
nx affected --target=lint --parallel=3 ✅ Succeeded 2m 21s View ↗
nx-cloud record -- yarn nx format:check ✅ Succeeded 5s View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗

☁️ Nx Cloud last updated this comment at 2026-10-14 09:00:05 UTC

@codecov

codecov Bot commented Oct 12, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 77.92208% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.67%. Comparing base (487b60a) to head (ac57956).
⚠️ Report is 8 commits behind head on staging.

Files with missing lines Patch % Lines
...rnal-secrets/add-secret-modal/add-secret-modal.tsx 75.75% 5 Missing and 3 partials ⚠️
...tainer-variables/step-variables/step-variables.tsx 44.44% 4 Missing and 1 partial ⚠️
.../src/lib/external-secrets/external-secrets-tab.tsx 86.20% 0 Missing and 4 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           staging    #3093      +/-   ##
===========================================
- Coverage    52.48%   51.67%   -0.82%     
===========================================
  Files          744     1387     +643     
  Lines        18789    31044   +12255     
  Branches      5731     9143    +3412     
===========================================
+ Hits          9862    16042    +6180     
- Misses        7357    12455    +5098     
- Partials      1570     2547     +977
Flag Coverage Δ
unittests 51.67% <77.92%> (-0.82%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@TheoGrandin74